BIND 10 #1003: root logger names

[BIND 10 Development]

#1003: root logger names
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jinmei
                       Type:  task   |                Status:  reviewing
                   Priority:  major  |             Milestone:
                  Component:         |  Sprint-20110802
  logging                            |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  Core
Feature Depending on Ticket:         |  Estimated Difficulty:  2.0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 stephen]:

 The revised version basically looks okay.  Please feel free to merge.

 One follow up comment:

 > > Is it safe to call LOG_xxx in getRelatedLoggers(). I don't follow all
 possible control flows, but this seems to be producing a log message while
 configuring logging, which looks fragile.
 > In this case it is OK.  The messages are generated during the parsing of
 the configuration and construction of the data structure used to modify
 the logging.  During this process, messages can be safely logged using
 whatever is the current logging configuration.

 This code path seems to be called in itialization, too (e.g., from
 ModuleCCSession::addRemoteConfig() via the ModuleCCSession
 constructor), not only at the update time.  I'm not sure if this
 really cause a problem or some kind of counter intuitive behavior, but
 if so, I'd suggest creating a separate ticket for that (on closer look
 this doesn't seem to be specific to getRelatedLoggers().  The
 ModuleCCSession itself has LOG_xxx in it, for example).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1003#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development