BIND 10 #926: Possibility to specify variable keys for map in configuration

[BIND 10 Development]

#926: Possibility to specify variable keys for map in configuration
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  7.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Few small things:
  * This seems to be a result of copy-paste, the name of exception probably
 means DataNotFoundError:
 {{{#!python
 except isc.cc.data.DataAlreadyPresentError as dnfe
 }}}
  * This looks strange (the apostrophes around some words):
 {{{#!c++
 // either a 'normal' map or a 'named' set
 }}}
  * The `pass` here seems extra:
 {{{#!python
             result.append(prefix[:-1])
             pass
 }}}
  * The changes in `get_default_value` would probably deserve some
 explanation or comments. I'm lost in the code.

 Generally, the config_data code looks hairy. But maybe it's because it is
 built from special cases for different configuration types and such, that
 the hairiness is in the nature of problem being solved. Anyway, even if it
 isn't, cleaning it up probably isn't part of this task.

 With regards

-- 
Ticket URL: <http://bind10.isc.org/ticket/926#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development