BIND 10 #926: Possibility to specify variable keys for map in configuration

[BIND 10 Development]

#926: Possibility to specify variable keys for map in configuration
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  7.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:8 vorner]:
 > Hello
 >
 > Few small things:
 >  * This seems to be a result of copy-paste, the name of exception
 probably means DataNotFoundError:
 > {{{#!python
 > except isc.cc.data.DataAlreadyPresentError as dnfe
 > }}}

 ack, changed to 'dape'

 >  * This looks strange (the apostrophes around some words):
 > {{{#!c++
 > // either a 'normal' map or a 'named' set
 > }}}

 updated comment

 >  * The `pass` here seems extra:
 > {{{#!python
 >             result.append(prefix[:-1])
 >             pass
 > }}}

 ack, removed the pass

 >  * The changes in `get_default_value` would probably deserve some
 explanation or comments. I'm lost in the code.
 >


 I've added a bit of rationale inline, but:

 > Generally, the config_data code looks hairy. But maybe it's because it
 is built from special cases for different configuration types and such,
 that the hairiness is in the nature of problem being solved. Anyway, even
 if it isn't, cleaning it up probably isn't part of this task.
 >

 I agree. We need to make these into nice classes and stop mucking around
 with raw data (especially for specification (parts))

-- 
Ticket URL: <http://bind10.isc.org/ticket/926#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development