BIND 10 #929: Add an interface into cfgmgr to get statistics list of each module

BIND 10 Development do-not-reply at isc.org
Thu Jul 28 09:05:06 UTC 2011


#929: Add an interface into cfgmgr to get statistics list of each module
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110802
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  configuration                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  15.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => naokikambe


Comment:

 Replying to [comment:8 naokikambe]:
 > > in validate_statistics():
 > >
 > > {{{if stat_spec != None:}}}
 > >
 > > this should work correctly (in general), but it is slightly better to
 use
 > >
 > > {{{if stat_spec is not None:}}}
 >
 > I fixed in the former way as you pointed out. I pushed git
 211f6c58e8cd6311eaca0a2ba181c4bfb379476c in tac929. Please see it.
 >

 Actually, this is indeed better than just 'if stat_spec', but what i
 really meant was that 'is not None' is preferrable over '!= None' (more
 efficient and cleaner). I realize that I had myself not used this, so to
 make up for it I replaced all 12 occurrences (in your branch), please see
 commit e54237acf184e5dc6d03409869b525152a259f2a.


 However, I now get a new problem, when I start bind10 locally, the
 statistics module keeps exiting with a stacktrace due to a bad statistics
 specification (for the timestamp with format 'second'). Do you see this as
 well?

-- 
Ticket URL: <http://bind10.isc.org/ticket/929#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list