BIND 10 #929: Add an interface into cfgmgr to get statistics list of each module
BIND 10 Development
do-not-reply at isc.org
Fri Jul 29 12:59:03 UTC 2011
#929: Add an interface into cfgmgr to get statistics list of each module
-------------------------------------+-------------------------------------
Reporter: | Owner: jelte
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110802
Priority: major | Resolution:
Component: | Sensitive: 0
configuration | Sub-Project: DNS
Keywords: | Estimated Difficulty: 15.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by naokikambe):
* owner: naokikambe => jelte
Comment:
Replying to [comment:9 jelte]:
> Actually, this is indeed better than just 'if stat_spec', but what i
really meant was that 'is not None' is preferrable over '!= None' (more
efficient and cleaner). I realize that I had myself not used this, so to
make up for it I replaced all 12 occurrences (in your branch), please see
commit e54237acf184e5dc6d03409869b525152a259f2a.
Thank you for fixing my inappropriate way and sorry for my
misunderstanding. The all changes are good.
> However, I now get a new problem, when I start bind10 locally, the
statistics module keeps exiting with a stacktrace due to a bad statistics
specification (for the timestamp with format 'second'). Do you see this as
well?
Thank you for notice. I couldn't find there was that runtime error on
stats and stats_httpd. The reason of that error was that stats-schema.spec
had the invalid format_type in the timestamp item. I fixed that and also
modified mock !ModuleSpec under the stats/tests/isc/config. But Those will
be removed in #930. Please see git
847df8f9c0ccd43f296e79df6ecd92d77e3da32a and
c290f8bb897e45d304b2895c394a421f46a2ee68, and please check whether there
is no more runtime error on stats and stats_httpd if possible. Of course,
I've already checked both.
Best
--
Ticket URL: <http://bind10.isc.org/ticket/929#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list