BIND 10 #1060: introduce the abstract DataSourceClient and ZoneHandle classes
BIND 10 Development
do-not-reply at isc.org
Thu Jul 28 10:18:54 UTC 2011
#1060: introduce the abstract DataSourceClient and ZoneHandle classes
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110802
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:9 jinmei]:
> A few more points:
> - maybe we shoud rename variables like 'zone' to 'zone_finder' (or if
> it's too long something like 'zfinder')
I tried to find them, but I must admit, it is hard without reading through
all our code, which would take a long time. Could we just keep fixing the
names as we go or live with this?
> - MemoryZoneFinder should be named InMemoryZoneFinder (for
> consistency)?
Renamed.
> - I think InMemoryClient::addZone() should better take
> MemoryZoneFinder (because it's specific to this derived class), but
> I found it would require changes to auth server tests and may make
> this branch unnecessarily big. So I'm okay to defer it to a
> separate ticket.
I agree with the ticket, let's create one when this is merged.
--
Ticket URL: <http://bind10.isc.org/ticket/1060#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list