BIND 10 #1060: introduce the abstract DataSourceClient and ZoneHandle classes
BIND 10 Development
do-not-reply at isc.org
Thu Jul 28 13:25:54 UTC 2011
#1060: introduce the abstract DataSourceClient and ZoneHandle classes
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110802
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:11 vorner]:
> > A few more points:
> > - maybe we shoud rename variables like 'zone' to 'zone_finder' (or if
> > it's too long something like 'zfinder')
>
> I tried to find them, but I must admit, it is hard without reading
through all our code, which would take a long time. Could we just keep
fixing the names as we go or live with this?
Okay.
I made a couple of trivial/minor fixes, with which I think this branch
can be merged.
One other thing I forgot to mention in the previous comment:
{{{
// TODO: Do we still need the PImpl if nobody should manipulate this
class
// directly any more (it should be handled through DataSourceClient)?
}}}
I guess pimpl will become less important for this class (but note that
it's explicitly used in auth at the moment). If avoiding pimpl
improves readability, etc, I have no problem with making that change.
--
Ticket URL: <http://bind10.isc.org/ticket/1060#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list