BIND 10 #978: Generic simplified ACL loader

[BIND 10 Development]

#978: Generic simplified ACL loader
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  ACL    |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 I've corrected a couple of typos and pushed the changes, to please rememer
 to pull before making any changes.

 '''src/lib/acl/loader.h'''
 It would help if the header would summarise what form the JSON is expected
 to take (e.g. there is reference to an "action" key which is not mentioned
 in the [wiki:AclSyntax described syntax]).

 Does the destructor for !LoaderError need the "throw()" specification?  We
 don't use it anywhere else.

 You may want to consider extending exceptions.h to add a macro
 ("isc_throw_1" say) to handle the extra argument when raising an
 exception.  The !LoaderError exception is raised enough times to make it
 worthwhile.

 class !CheckCreator: the header to allowListAbbreviation() refers to a
 parameter.  Is this the second parameter to the create() call?  If so,
 this ought to be made clear.

 class Loader/!CheckCreator: a summary in the class header of how this is
 used would be helpful.  At present a number of method headers have to be
 read to work out you can register multiple !CheckCreators, each of which
 can respond to a number of names.

-- 
Ticket URL: <http://bind10.isc.org/ticket/978#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development