BIND 10 #978: Generic simplified ACL loader

[BIND 10 Development]

#978: Generic simplified ACL loader
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110628
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  ACL    |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Replying to [comment:8 stephen]:
 > '''src/lib/acl/loader.h'''
 > It would help if the header would summarise what form the JSON is
 expected to take (e.g. there is reference to an "action" key which is not
 mentioned in the [wiki:AclSyntax described syntax]).

 The one on wiki is slightly outdated, it describes the non-sequential
 syntax. It should be updated sometime or deleted and a proper user
 documentation written (I don't believe I would be good at that).

 Anyway, I put something to the doxygen comment, it should be enough for
 now. We can't directly use it for users, as it describes generic things
 that would be fixed for the end users.

 > Does the destructor for !LoaderError need the "throw()" specification?
 We don't use it anywhere else.

 Yes, it's needed, because we inherint from exception, that has virtual
 destructor with throw(). As this class adds a member which has a
 destructor and does not have throw() declaration at it, it is
 theoretically possible the destructor could throw, so it is needed to
 declare it doesn't (or it won't compile).

 > You may want to consider extending exceptions.h to add a macro
 ("isc_throw_1" say) to handle the extra argument when raising an
 exception.  The !LoaderError exception is raised enough times to make it
 worthwhile.

 I wish we had C99 variadic macros. Well, hopefully we won't create too
 many parameters.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/978#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development