BIND 10 #575: Port the way addresses are configured from resolver to auth.

[BIND 10 Development]

#575: Port the way addresses are configured from resolver to auth.
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  vorner
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110309
                Component:           |           Resolution:
  b10-auth                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by zzchen_pku):

 * owner:  zzchen_pku => vorner


Comment:

 Hello

 Review done, please find comments below:
 '''trac575-parts/2-parseAddress'''
  - resolver/resolver.cc
   * updateConfig() has a typo: "forward_addresse"  ->  "forward_addresses"
   * just a suggestion, vector<AddressPair> can be replaced by AddressList,
 I found both of them in the source.
  - portconfig_unittest.cc
   * we'd better add multi address config test for ParseAddresses
  - portconfig.cc and portconfig_unittest.cc
   * #include "###" and be replaced by #include <###> for consistency
 '''trac575-parts/4-address-interface'''
  - auth_srv.h
   * The comments is confusing, I think it is copied from some place
 without change:-)
 {{{
 "Assign an ASIO DNS Service queue to this Resolver object"
 }}}

 '''trac575-parts/5-config'''
   - testutils/portconfig.h
    * It is not correct any more, since #388 has been merged into master.
 {{{
 * \param server The server object to test against.
 * \todo This tests currently aborts due to #388 (it is impossible to close
 *     sockets, so it is impossible to configure, deconfigure and then
 *     configure them again). Once #388 is solved, enable the tests.
 }}}
   - auth/config.cc
     * #include <memory>. It seems the header file is not required.

-- 
Ticket URL: <http://bind10.isc.org/ticket/575#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development