BIND 10 #575: Port the way addresses are configured from resolver to auth.

BIND 10 Development do-not-reply at isc.org
Wed Mar 2 12:06:15 UTC 2011


#575: Port the way addresses are configured from resolver to auth.
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  zzchen_pku
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  A-Team-
                 Priority:  major    |  Sprint-20110309
                Component:           |           Resolution:
  b10-auth                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  5.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => zzchen_pku


Comment:

 Hello

 Replying to [comment:7 zzchen_pku]:
 >  - portconfig.cc and portconfig_unittest.cc
 >   * #include "###" and be replaced by #include <###> for consistency

 Done, I agree with the consistency, but I believe we use it consistently
 wrong. We don't need include path search for local headers. But anyway,
 that's a different discussion.

 > '''trac575-parts/4-address-interface'''
 >  - auth_srv.h
 >   * The comments is confusing, I think it is copied from some place
 without change:-)

 It was, how did you tell I copied it? ;-)

 >   * It is not correct any more, since #388 has been merged into master.

 This required a merge with master. I fixed some conflicts there and
 enabled all the tests that were disabled before.

 So, the branch has 4 more commits. The 3 last ones are trivial fixes, but
 the 4th from the head (fa05a534849c2e3ba68d6fdc4c5ddc6531948fc3) is a non-
 trivial merge.

 If you want to see the diff of whole branch, git diff
 0a9ce967a515894bd7c46cf86a6ff4bc3d856b3a.. would do it. For some reason,
 git show fa05a534849c2e3ba68d6fdc4c5ddc6531948fc3 shows quite a lot of
 noise around. It looks like git is unable to get rid of it, but most of
 the lines that start with ' +' (+ in the second column) look
 uninteresting. It might help enabling colors for git diff a little.

 Anyway, I believe all the things you mention are addressed.

 Thank you

-- 
Ticket URL: <https://bind10.isc.org/ticket/575#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list