BIND 10 #610: Stop/Start/Run tests of b10-auth

BIND 10 Development do-not-reply at isc.org
Wed Mar 9 10:03:28 UTC 2011


#610: Stop/Start/Run tests of b10-auth
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110309
  b10-auth                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  3.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 I agree the changelog is probably more spam in this case than useful
 information.

 With the code and tests, I mostly agree they are OK, but I still have some
 comments:
  - There was a stray copy-pasted comment (updated)
  - Typo ("HOMEE") in the bindctl tests (updated)
  - The tests failed for me the first time. I discovered that my sh doesn't
 expand \n in single quotes (AFAIK it even shouldn't). So I replaced them
 with real newlines. It runs then.
  - Should there be some tests for the command line parsing? (for bindctl)
  - What is the purpose of n=`expr $n+1` in the test? I don't see the n
 being used anywhere and it just keeps increasing unconditionally after
 each test.

 Please check if the changes I propose are OK.

 Thanks

-- 
Ticket URL: <https://bind10.isc.org/ticket/610#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list