BIND 10 #610: Stop/Start/Run tests of b10-auth

[BIND 10 Development]

#610: Stop/Start/Run tests of b10-auth
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110316
  b10-auth                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  3.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 vorner]:
 > Hello
 >
 > I agree the changelog is probably more spam in this case than useful
 information.
 >
 > With the code and tests, I mostly agree they are OK, but I still have
 some comments:
 >  - There was a stray copy-pasted comment (updated)
 >  - Typo ("HOMEE") in the bindctl tests (updated)
 >  - The tests failed for me the first time. I discovered that my sh
 doesn't expand \n in single quotes (AFAIK it even shouldn't). So I
 replaced them with real newlines. It runs then.

 > Please check if the changes I propose are OK.

 The changes are okay.  Thanks for fixing them.

 >  - Should there be some tests for the command line parsing? (for
 bindctl)

 I may misunderstand it, but I think such tests should go to bindctl
 itself.

 >  - What is the purpose of n=`expr $n+1` in the test? I don't see the n
 being used anywhere and it just keeps increasing unconditionally after
 each test.

 It's a convention of BIND 9 system tests (probably introduced at a
 later stage - as we saw the glue tests don't have it).  My
 understanding is that it helps check the corresponding log (such as
 dig output) on failure.

 For example, if we see:
 {{{
 I:Checking b10-auth is working by default (0)
 I:failed
 }}}

 it means we may want to check dig.out.0 to see what went wrong.

-- 
Ticket URL: <http://bind10.isc.org/ticket/610#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development