BIND 10 #501: NSAS Glue Corrections

[BIND 10 Development]

#501: NSAS Glue Corrections
-------------------------------------+-------------------------------------
                 Reporter:  shane    |                Owner:  jelte
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  minor    |  Sprint-20110316
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  10.0     |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 '''src/lib/nsas/glue_hints.{cc,h}'''[[BR]]
 A message is being output to stdout in the !GlueHints constructor.

 A matter of preference, but as they are very much tied to glue - and take
 as arguments the address vectors (i.e. all the member variables of the
 !GlueHints class) - I would suggest that addGlueForRRset() and
 addGlueForName() are better defined as private methods in the class.


 '''src/lib/nsas/nameserver_address.h'''[[BR]]
 Why was the "nameserver" argument in the !NameserverAddress constructor
 changed from passed by reference to being passed by value?


 '''src/lib/resolve/recursive_query.cc'''[[BR]]
 Not really related to this change, but the variable found_ns_address is
 mis-named as it only indicates whether an NS record has been found -
 found_ns is better.

-- 
Ticket URL: <http://bind10.isc.org/ticket/501#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development