BIND 10 #501: NSAS Glue Corrections

[BIND 10 Development]

#501: NSAS Glue Corrections
-------------------------------------+-------------------------------------
                 Reporter:  shane    |                Owner:  stephen
                     Type:           |               Status:  reviewing
  enhancement                        |            Milestone:  R-Team-
                 Priority:  minor    |  Sprint-20110316
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  10.0     |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 Replying to [comment:4 stephen]:
 > '''src/lib/nsas/glue_hints.{cc,h}'''[[BR]]
 > A message is being output to stdout in the !GlueHints constructor.
 >

 oops removed.

 > A matter of preference, but as they are very much tied to glue - and
 take as arguments the address vectors (i.e. all the member variables of
 the !GlueHints class) - I would suggest that addGlueForRRset() and
 addGlueForName() are better defined as private methods in the class.
 >

 Ack. Initially I had everything as private, which didn't make sense. I
 guess i overdid it a bit :)

 >
 > '''src/lib/nsas/nameserver_address.h'''[[BR]]
 > Why was the "nameserver" argument in the !NameserverAddress constructor
 changed from passed by reference to being passed by value?
 >

 oops, I was doing some experimenting regarding a null shared_ptr, and was
 wondering if passing them by reference if you know you'll copy them was a
 bad idea or not (still not entirely sure about that, btw). Re-added the
 ref.

 >
 > '''src/lib/resolve/recursive_query.cc'''[[BR]]
 > Not really related to this change, but the variable found_ns_address is
 mis-named as it only indicates whether an NS record has been found -
 found_ns is better.

 ack. Changed it.

 See commit 629023f290c290441129c96b11ece7de299fb8a6

-- 
Ticket URL: <https://bind10.isc.org/ticket/501#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development