BIND 10 #658: Check qid of responses

[BIND 10 Development]

#658: Check qid of responses
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  jelte
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  resolver                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 OK, ignore my last comments, I've reviewed trac658_new now ;-)


 '''src/lib/asiolink/tests/io_fetch_unittest.c'''[[BR]]
 udpReceiveHandler: should extend Doxygen description of argument list with
 new arguments.  (However, there appears to be only one case where they are
 used - in !UdpSendReceive - and both are set to false.  Are they needed?)

 IOFetchTest::operator(): where the expected result is checked, two lines
 are commented out.

 With the addition of the QID check, it does occur to me that a missing
 test is to check that the I/O times out if the remote TCP server does not
 send back enough data.

 '''src/lib/resolve/tests/recursive_query_unittest_2.cc'''[[BR]]
 checkReceivedPacket now returns the QID, although all calls ignore the
 returned value.

-- 
Ticket URL: <https://bind10.isc.org/ticket/658#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development