BIND 10 #658: Check qid of responses

[BIND 10 Development]

#658: Check qid of responses
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  stephen
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  resolver                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 Replying to [comment:11 stephen]:
 > OK, ignore my last comments, I've reviewed trac658_new now ;-)
 >
 >
 > '''src/lib/asiolink/tests/io_fetch_unittest.c'''[[BR]]
 > udpReceiveHandler: should extend Doxygen description of argument list
 with new arguments.  (However, there appears to be only one case where
 they are used - in !UdpSendReceive - and both are set to false.  Are they
 needed?)

 oops, both the descriptions and the tests that used them did not make the
 transition :/

 added them both. (in fact i moved the original udpsendreceivetest to be a
 that takes those two methods, and added two tests, one that checks if
 there is a timeout if the qid doesn't match, and one that checks if there
 is success if the first answer does not match but the second one does,
 this actually made me find a bug; fetchdata->received should be cleared
 before doing a (second) async_receive()

 >
 > IOFetchTest::operator(): where the expected result is checked, two lines
 are commented out.
 >

 they should have been removed, done.

 > With the addition of the QID check, it does occur to me that a missing
 test is to check that the I/O times out if the remote TCP server does not
 send back enough data.
 >

 i can see if i can add a test for that, returning this ticket now anyway

 > '''src/lib/resolve/tests/recursive_query_unittest_2.cc'''[[BR]]
 > checkReceivedPacket now returns the QID, although all calls ignore the
 returned value.

 oh right, that makes some of the code two lines shorter, done, thanks :)

-- 
Ticket URL: <https://bind10.isc.org/ticket/658#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development