BIND 10 #678: UDPServer and TCPServer classes need clenup and tests.
BIND 10 Development
do-not-reply at isc.org
Wed Mar 16 08:59:40 UTC 2011
#678: UDPServer and TCPServer classes need clenup and tests.
-------------------------------------+-------------------------------------
Reporter: vorner | Owner: hanfeng
Type: defect | Status: reviewing
Priority: | Milestone: A-Team-
critical | Sprint-20110316
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Add Hours to Ticket: 0
Estimated Number of Hours: 0.0 | Total Hours: 0
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => hanfeng
Comment:
Hello
Replying to [comment:8 hanfeng]:
> > You link against a boost library. We decided we don't want to link
against that I believe.
>
> alarm isn't in standard c which is included in unistd.h, It isn't a
problem now since we are only supporting unix-like system and in the code
base, several place including it. So I replace the thread with alarm. But
it looks a little wired, cause it's a little low level:)
I see your concern, once we go for Windows, we might have a need to do
something about it. But, strictly speaking, boost thread's aren't standard
C/C++ either.
Anyway, I fixed small bug, I tried disabling the stop() call (by making it
empty) and discovered it doesn't stop, and found that if we call .stop()
directly followed by .reset(), it does nothing. I pushed the change.
If you are OK with this change, I believe it can be merged.
Thanks
--
Ticket URL: <https://bind10.isc.org/ticket/678#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list