BIND 10 #678: UDPServer and TCPServer classes need clenup and tests.
BIND 10 Development
do-not-reply at isc.org
Wed Mar 16 11:53:42 UTC 2011
#678: UDPServer and TCPServer classes need clenup and tests.
-------------------------------------+-------------------------------------
Reporter: vorner | Owner: hanfeng
Type: defect | Status: reviewing
Priority: | Milestone: A-Team-
critical | Sprint-20110316
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Add Hours to Ticket: 0
Estimated Number of Hours: 0.0 | Total Hours: 0
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by hanfeng):
> I see your concern, once we go for Windows, we might have a need to do
something about it. But, strictly speaking, boost thread's aren't standard
C/C++ either.
Sure, boost thread isn't included in c++ standard library, but it hide the
low level implementation, so the portability is ok. Nothing needs modify
if we want to support windows.
> Anyway, I fixed small bug, I tried disabling the stop() call (by making
it empty) and discovered it doesn't stop, and found that if we call
.stop() directly followed by .reset(), it does nothing. I pushed the
change.
ok, I move the reset to the place after run, and since we call reset after
run, io service will be ok for next run, so I remove the stop and reset in
each SetUp, I tested the empty stop, everything is ok, i will merge the
code.
--
Ticket URL: <http://bind10.isc.org/ticket/678#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list