BIND 10 #745: Conversion of nsas library to use the new logging interface

BIND 10 Development do-not-reply at isc.org
Tue May 10 11:11:59 UTC 2011


#745: Conversion of nsas library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:         |             Sensitive:  0
  resolver                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  logging                            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Just two minor points:
  * I'm little bit surprised by your indentation/line breaking. Having each
 .arg on a new line even when more of them would fit into the same line
 looks little bit wasting of space to me. But I guess nothing in our style
 guidelines would be against that, so if you like it this way, it's OK.
  * RRtype doesn't need .toText() within the .arg call, it is converted
 automatically, so the .arg(type_.toText()) calls can be simplified.

 I think this is simple enough so it won't need another review cycle. Just
 merge after this.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/745#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list