BIND 10 #745: Conversion of nsas library to use the new logging interface
BIND 10 Development
do-not-reply at isc.org
Tue May 10 13:53:37 UTC 2011
#745: Conversion of nsas library to use the new logging interface
-------------------------------------+-------------------------------------
Reporter: | Owner: stephen
stephen | Status: closed
Type: | Milestone:
enhancement | Sprint-20110517
Priority: minor | Resolution: complete
Component: | Sensitive: 0
resolver | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
logging |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* status: reviewing => closed
* resolution: => complete
Comment:
> RRtype doesn't need .toText() within the .arg call, it is converted
automatically, so the .arg(type_.toText()) calls can be simplified.
Done.
> I'm little bit surprised by your indentation/line breaking. Having each
.arg on a new line even when more of them would fit into the same line
looks little bit wasting of space to me. But I guess nothing in our style
guidelines would be against that, so if you like it this way, it's OK.
That was in part to break up what would have been a very long string of
text. Removing the .toText() has shortened the arguments, so I've
combined some .arg() calls on the same line.
Committed as b653f950b906ecf4194d2a2cd07fa92ae47dd546
--
Ticket URL: <http://bind10.isc.org/ticket/745#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list