BIND 10 #744: Conversion of data source library to use the new logging interface

[BIND 10 Development]

#744: Conversion of data source library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  logging                            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 '''src/lib/datasrc/memory_datasrc.cc'''[[BR]]
 As there are already some calls to LOG_DEBUG in the code, I would suggest
 that remaining "logger.debug" calls be replaced with it for consistency.
 (This applies to other files as well.)

 A more general question that perhaps should go to bind10-dev: there are a
 number of constructs along the lines of:
 {{{
 logger.error(DATASRC_QUERY_MISSING_NS).arg(*zonename);
 isc_throw(DataSourceError,
           NS RR not found in " << *zonename << "/" << q.qclass());
 }}}
 Should we create a ticket to allow isc_throw to take the message ID and
 arguments, e.g.
 {{{
 isc_throw(DataSourceError, DATASRC_QUERY_MISSING_NS)
           .arg(*zonename).arg(q.qclass());
 }}}
 ... perhaps even providing variations of the macro that would log the
 error as well.


 '''src/lib/datasrc/tests/Makefile.am'''[[BR]]
 I had to add some libraries to the link command to get the tests to build
 under Ubuntu 10.10 (and have pushed the changes - commit
 2b521f9674a0d9aea7fb06d71b008e64c40922aa).

-- 
Ticket URL: <http://bind10.isc.org/ticket/744#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development