BIND 10 #744: Conversion of data source library to use the new logging interface

[BIND 10 Development]

#744: Conversion of data source library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  logging                            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Replying to [comment:8 stephen]:
 > '''src/lib/datasrc/memory_datasrc.cc'''[[BR]]
 > As there are already some calls to LOG_DEBUG in the code, I would
 suggest that remaining "logger.debug" calls be replaced with it for
 consistency. (This applies to other files as well.)

 OK, if you really prefer them. I still find macros ugly, but it took me
 few replaces only.

 > A more general question that perhaps should go to bind10-dev: there are
 a number of constructs along the lines of:
 > {{{
 > logger.error(DATASRC_QUERY_MISSING_NS).arg(*zonename);
 > isc_throw(DataSourceError,
 >           NS RR not found in " << *zonename << "/" << q.qclass());
 > }}}
 > Should we create a ticket to allow isc_throw to take the message ID and
 arguments, e.g.

 I vote for just creating the ticket. We hardly ever get any answer from
 the dev list and it makes sense, in  worst case, the ticket can be
 dropped. I'll do it when I merge this.

 > '''src/lib/datasrc/tests/Makefile.am'''[[BR]]
 > I had to add some libraries to the link command to get the tests to
 build under Ubuntu 10.10 (and have pushed the changes - commit
 2b521f9674a0d9aea7fb06d71b008e64c40922aa).

 This indicates something rotten I guess, the datasrc library should bring
 exceptions & co. with itself in LIBADD, this shouldn't be needed. Do we
 just put them there and ignore it when this cures the symptoms or should
 we create a ticket or something to investigate?

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/744#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development