BIND 10 #739: Conversion of b10-resolver to use the new logging interface

BIND 10 Development do-not-reply at isc.org
Tue May 24 17:21:42 UTC 2011


#739: Conversion of b10-resolver to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110531
                   Priority:  minor  |            Resolution:
                  Component:         |             Sensitive:  0
  resolver                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Only few details:
  * Shouldn't the header include everything?
 {{{
 -#include <log/dummylog.h>
 +#include <log/macros.h>
 +#include <log/logger_support.h>
 +#include <log/debug_levels.h>
 +#include "resolver_log.h"
 }}}
  * '.arg(answer_message->toText())' → '.arg(*answer_message)'
  * '.arg(config->toWire())' → '.arg(*config)'
    (these seem nicer to me, but it's probably matter of preference, so no
 big deal if you want it this way)

 With regards

-- 
Ticket URL: <http://bind10.isc.org/ticket/739#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list