BIND 10 #739: Conversion of b10-resolver to use the new logging interface
BIND 10 Development
do-not-reply at isc.org
Wed May 25 11:15:52 UTC 2011
#739: Conversion of b10-resolver to use the new logging interface
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
stephen | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110531
Priority: minor | Resolution:
Component: | Sensitive: 0
resolver | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => vorner
Comment:
> Shouldn't the header include everything?
I've taken out <log/macros.h> from main.cc as it is included in
resolver_log.h. The other two includes - logger_support.h and
debug_levels.h - are only used by main.cc so I felt that they were better
explicitly included in that file.
> '.arg(answer_message->toText())' → '.arg(*answer_message)'
> '.arg(config->toWire())' → '.arg(*config)' (these seem nicer to me, but
it's probably matter of preference, so no big deal if you want it this
way)
They were direct translations from the original dlog() calls. However,
the ability to pass objects to the .arg() calls without the need to call
methods to get the string representation is very convenient and does make
the code clearer. I've made the changes suggested (and in a couple of
other places where there was a toText() call).
--
Ticket URL: <http://bind10.isc.org/ticket/739#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list