BIND 10 #1217: Error in automatically updating TTLs that do not match in an RRset

BIND 10 Development do-not-reply at isc.org
Tue Nov 1 14:12:09 UTC 2011


#1217: Error in automatically updating TTLs that do not match in an RRset
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jelte
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:         |  Estimated Difficulty:  5
  Medium                             |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 Reviewed commit 701ffebae5b357a693e764bbef904dc374ebb591

 '''src/lib/datasrc/memory_datasrc.{h,cc}'''[[BR]]
 > As for the memory backend, the tests are still disabled (#1346), and in
 the source the parameter is ignored, and might not even be relevant, as
 the data is already stored as rrsets (so if not stored individually, the
 ttl info is already lost)
 This may prove surprising if future code attempts to iterate through a
 zone one RR at a time.  Rather than the individual_rr parameter being
 ignored, I would suggest either:
 * Implementing the functionality.
 * Check the value of the argument and if true, throw a !NotImplemented
 exception.

 '''src/lib/datasrc/tests/database_unittest.cc'''[[BR]]
 ttldiff_individual test: within the "while" loop, the "if" test should
 include an "else" branch which calls FAIL().  (Just an additional check
 that the data is as expected.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1217#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list