BIND 10 #1217: Error in automatically updating TTLs that do not match in an RRset

[BIND 10 Development]

#1217: Error in automatically updating TTLs that do not match in an RRset
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  stephen
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:         |  Estimated Difficulty:  5
  Medium                             |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 Replying to [comment:11 stephen]:
 > * Implementing the functionality.
 > * Check the value of the argument and if true, throw a !NotImplemented
 exception.
 >

 Neither option really appealed to me, tbh; the first would just be a waste
 of resources, and the second would make the option useless (we will need
 it for some cases like xfrout, and then we will always need it)

 So i opted for a slightly different approach; more in line with what i
 originally had in mind actually; i've changed the argument to
 'adjust_ttl', if true, it will behave as it used to (if they differ,
 modify). If false, it will view a different ttl as an indicator that the
 RR belongs to a different RRset.

 How's that?

 > '''src/lib/datasrc/tests/database_unittest.cc'''[[BR]]
 > ttldiff_individual test: within the "while" loop, the "if" test should
 include an "else" branch which calls FAIL().  (Just an additional check
 that the data is as expected.)

 ack, added

-- 
Ticket URL: <http://bind10.isc.org/ticket/1217#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development