BIND 10 #1390: update b10-auth to pass IXFR-request to xfrout

[BIND 10 Development]

#1390: update b10-auth to pass IXFR-request to xfrout
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by vorner):

 Hello

 I made a small whitespace change, there were spaces at the end of lines.

 As for the comments to the branch:
  * In the test checking the successful scenario, should it check that the
 auth provides no answer at all?
  * There are two „# TODO: Log?“. Maybe we should decide and maybe really
 log.
  * Indentation here (the lower line doesn't start at just after the
 opening parenthesis):
 {{{#!diff
 -            sendAnswer = impl_->processAxfrQuery(io_message, message,
 buffer,
 +            sendAnswer = impl_->processXfrQuery(io_message, message,
 buffer,
                                                   tsig_context);
 }}}

 {{{#!diff
 -            makeErrorMessage(message, buffer, Rcode::NOTIMP(),
 tsig_context);
 +            sendAnswer = impl_->processXfrQuery(io_message, message,
 buffer,
 +                                                 tsig_context);
 }}}

 This one many times:
 {{{#!diff
 +    UnitTestUtil::createRequestMessage(request_message, opcode,
 default_qid,
 +                         Name("example.com"), RRClass::IN(),
 RRType::IXFR());
 }}}

 This changes the external behaviour, so I think this would need a
 changelog entry.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/1390#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development