BIND 10 #1390: update b10-auth to pass IXFR-request to xfrout

[BIND 10 Development]

#1390: update b10-auth to pass IXFR-request to xfrout
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:4 vorner]:
 > Hello
 >
 > I made a small whitespace change, there were spaces at the end of lines.
 >

 thanks

 > As for the comments to the branch:
 >  * In the test checking the successful scenario, should it check that
 the auth provides no answer at all?

 Ack. Also fixed the inline comments that were still talking about
 AXFR. And, for completeness, added the same check to the similar AXFR
 test.

 >  * There are two „# TODO: Log?“. Maybe we should decide and maybe
 really log.

 ack, three even :) added log messages. After a short bit of discussion
 on jabber, I've set these to debug level (otherwise externals could
 cause log spam), except for the one that should never even reach this
 part of the code. I also changed the acl reject/drop from info to
 debug, for the same reasoning.

 >  * Indentation here (the lower line doesn't start at just after the
 opening parenthesis):
 snip
 > This one many times:
 snip

 Fixed.

 >
 > This changes the external behaviour, so I think this would need a
 changelog entry.
 >

 Hmm, yes, I don't know if we were aiming for one Big Changelog
 message, but let's go for:

 [func]  jelte
 The b10-auth will no longer reply to IXFR requests with a NOTIMPL, but
 pass the IXFR request on to b10-xfrout (if running). Currently,
 pending #1371 and #1372, xfrout will not correctly respond to IXFR
 requests, but it will answer as if it was an AXFR.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1390#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development