BIND 10 #1371: IXFR-out protocol handling: normal case

[BIND 10 Development]

#1371: IXFR-out protocol handling: normal case
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  xfrout                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  6
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 I like how it turned out to work the same way for IXFR and AXFR.

 There are two things I noticed:
  * The `create_soa` and other `create_*` functions are twice in the source
 code, once in the creatediff.py, once xfrout_test.py. Would it be possible
 to have them in some common place just once?
  * The test `test_reply_xfrout_query_ixfr` checks only length of the
 answer? Is it enough? I noticed that generally the tests don't examine
 much about which RRs are there, only look at specific SOA or the count
 only.

 Thank you

-- 
Ticket URL: <https://bind10.isc.org/ticket/1371#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development