BIND 10 #1371: IXFR-out protocol handling: normal case

[BIND 10 Development]

#1371: IXFR-out protocol handling: normal case
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  xfrout                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  6
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 vorner]:

 Again, thanks for the prompt review.

 > I like how it turned out to work the same way for IXFR and AXFR.
 >
 > There are two things I noticed:
 >  * The `create_soa` and other `create_*` functions are twice in the
 source code, once in the creatediff.py, once xfrout_test.py. Would it be
 possible to have them in some common place just once?

 Yeah, I had that idea, too.  I was not sure if it made sense in this
 case as creatediff was mostly just for reference, but now is probably
 good time to do it.  It required a bit organizational change
 (introduce a new test-only module), but I did it.

 >  * The test `test_reply_xfrout_query_ixfr` checks only length of the
 answer? Is it enough? I noticed that generally the tests don't examine
 much about which RRs are there, only look at specific SOA or the count
 only.

 You're right, it's better to examine more data.  I was aware of that,
 but was a bit lazy to do this without either bigger organizational
 change or copy-paste utility functions.  Again, now pointed it out,
 I did it with a bit bigger organizational change.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1371#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development