BIND 10 #1304: xfrin test should retrieve config defaults from the spec file
BIND 10 Development
do-not-reply at isc.org
Thu Oct 13 22:31:18 UTC 2011
#1304: xfrin test should retrieve config defaults from the spec file
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | Status: new
Priority: major | Milestone: Next-
Component: xfrin | Sprint-Proposed
Sensitive: 0 | Keywords:
Sub-Project: DNS | Defect Severity: N/A
Estimated Difficulty: 0 | Feature Depending on Ticket:
Total Hours: 0 | Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Right now, it's hardcording some default values, which just happen to
be consistent with the spec file:
{{{
class MockCC():
def get_default_value(self, identifier):
# The returned values should be identical to the spec file
# XXX: these should be retrieved from the spec file
# (see MyCCSession of xfrout_test.py.in)
if identifier == "zones/master_port":
return TEST_MASTER_PORT
if identifier == "zones/class":
return TEST_RRCLASS_STR
if identifier == "zones/use_ixfr":
return False
}}}
Obviously it's ugly and more difficult to maintain. As commented the
mock class should retrieve the defaults from the spec file. We should
also have some tests to check whether the default values are really
used in other cases (such as "max transfer in").
--
Ticket URL: <http://bind10.isc.org/ticket/1304>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list