BIND 10 #1891: implement addRecordToNSEC3Zone and deleteRecordInNSEC3Zone for SQLite3 accessor

BIND 10 Development do-not-reply at isc.org
Wed Apr 18 12:55:28 UTC 2012


#1891: implement addRecordToNSEC3Zone and deleteRecordInNSEC3Zone for SQLite3
accessor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  low    |  Sprint-20120501
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:  NSEC3  |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Looks good, and can be merged, just two small comments:

 in sqlite3_accessor.cc. startUpdateZone(), the
 sqlite3_clear_bindings(stmt); line seems unnecessary (line 1048), since
 the !StatementProcessor should've already done that

 side note regarding that !StatementProcessor, its common use seems to
 suggest we should either provide argument bind() calls or a method
 sqlite3_stmt* StatementProcessor::getStatement();
 to use with the sqlite3_bind_XXX calls (probably the latter given the
 sqlite interface); so we do not need to both create a !StatementProcessor
 and a separate pointer for the statement just for binding. But not really
 in scope for this ticket I guess

-- 
Ticket URL: <http://bind10.isc.org/ticket/1891#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list