BIND 10 #1891: implement addRecordToNSEC3Zone and deleteRecordInNSEC3Zone for SQLite3 accessor

[BIND 10 Development]

#1891: implement addRecordToNSEC3Zone and deleteRecordInNSEC3Zone for SQLite3
accessor
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  low    |  Sprint-20120501
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:  NSEC3  |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:6 jelte]:

 > in sqlite3_accessor.cc. startUpdateZone(), the
 sqlite3_clear_bindings(stmt); line seems unnecessary (line 1048), since
 the !StatementProcessor should've already done that

 Ah, good catch, and while trying to address this, I also noticed the
 next point myself even before reading it:-)

 > side note regarding that !StatementProcessor, its common use seems to
 suggest we should either provide argument bind() calls or a method
 > sqlite3_stmt* StatementProcessor::getStatement();
 > to use with the sqlite3_bind_XXX calls (probably the latter given the
 sqlite interface); so we do not need to both create a !StatementProcessor
 and a separate pointer for the statement just for binding. But not really
 in scope for this ticket I guess

 So I did this too.  As commented in the commit log, I think it's safer
 so worth doing even if not directly related to the subject of this
 ticket.

 And one more thing: I forgot to enable some of DatabaseClientTest
 tests that were temporarily made the mock accessor only.  I did it at
 bcb62dd.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1891#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development