BIND 10 #1958: Implement perfdhcp statistics component

BIND 10 Development do-not-reply at isc.org
Tue Aug 7 12:41:54 UTC 2012


#1958: Implement perfdhcp statistics component
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  marcin
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120730
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  16
                   Keywords:         |           Total Hours:  65
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  9      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 Reviewed commit 2175b280a686cc4aec2cf72c21f7ce839bf609ee

 '''tests/tools/perfdhcp/stats_mgr.h'''[[BR]]
 getName()/getValue() etc - return value should be in brackets (as is the
 case in methods such as getMinDelay()).

 !ExchangeStats constructor requires description of archive_enabled
 parameter.

 I'm a bit unclear about the rcvd_packets_num_ counter.  It had previously
 been incremented in appendRcvd(), but is now incremented in findSent().
 Presumably this means that the counter is the number of packets received
 that corresponded to packets sent, and not the number of packets received.

 !StatsMgr constructor.  Only one version is needed - set the default value
 for the archive_enabled parameter to false.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1958#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list