BIND 10 #1958: Implement perfdhcp statistics component

[BIND 10 Development]

#1958: Implement perfdhcp statistics component
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120730
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  16
                   Keywords:         |           Total Hours:  67
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  2      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  9 => 2
 * owner:  marcin => stephen
 * totalhours:  65 => 67


Comment:

 I corrected the code as suggested.

 Regarding the rcvd_packets_num_ counter....
 The fact that increment operation was moved from appendRcvd() to
 findSent() (which has been now renamed to matchPackets()) does not change
 the behavior. This is because appendSent() was called only in case the
 received packet was matched with sent packet. I had to move this out from
 appendRcvd() because when so called 'archive mode' is disabled I neither
 store sent nor received packets once they are matched. In other words I
 never call appendRecvd() when archive mode is disabled but I still want to
 increment the counter. It seems to be the most natural place to do it
 where it is done now.

 I also decided to rename the findSent() function to matchPackets() which
 in my opinion better reflects the purpose of it. Not only does it find the
 'sent' packet but also it does other things like increment counters.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1958#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development