BIND 10 #2096: Define and implement "RdataReader" class
BIND 10 Development
do-not-reply at isc.org
Fri Aug 10 11:26:47 UTC 2012
#2096: Define and implement "RdataReader" class
-------------------------------------+-------------------------------------
Reporter: | Owner: UnAssigned
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120821
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
scalable inmemory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => UnAssigned
* status: accepted => reviewing
Comment:
Hello
Replying to [comment:11 jinmei]:
> Maybe you're going to change this, but I'm afraid we cannot reasonably
> pass the serialized data size to the `RDataReader` constructor,
> because this information wouldn't be (expected to be) stored on
> encoding (serialization).
I noticed it just now, when I decided to put it into review. Will the size
be a problem?
Currently, the passed size is used only for future result of getSize()
(which I don't really know the exact purpose, but anyway). So it can be
removed quite easily if it is a problem.
Anyway, to the code. I decided to provide dual interface ‒ allow both
using it with callbacks and the return value of next. I didn't completely
delete the parsing test code, but I moved it from the main source code to
the tests. I reuse the encoding tests for reading too.
--
Ticket URL: <http://bind10.isc.org/ticket/2096#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list