BIND 10 #2096: Define and implement "RdataReader" class
BIND 10 Development
do-not-reply at isc.org
Tue Aug 14 21:54:25 UTC 2012
#2096: Define and implement "RdataReader" class
-------------------------------------+-------------------------------------
Reporter: | Owner: UnAssigned
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120821
medium | Resolution:
Component: data | Sensitive: 0
source | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
scalable inmemory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:12 vorner]:
> > Maybe you're going to change this, but I'm afraid we cannot reasonably
> > pass the serialized data size to the `RDataReader` constructor,
> > because this information wouldn't be (expected to be) stored on
> > encoding (serialization).
>
> I noticed it just now, when I decided to put it into review. Will the
size be a problem?
>
> Currently, the passed size is used only for future result of getSize()
(which I don't really know the exact purpose, but anyway). So it can be
removed quite easily if it is a problem.
getSize() (named "getDataLength" in the ticket description) is
intended to be used to deallocate the memory region for the RDATA
along with `RdataSet`. And, the point is that getSize() needs to
calculate the length itself by exploring the internal encoded data,
not by being passed the value from somewhere else.
I've addressed this point in #2097 at commit e8849df, and
cherry-picked it into this branch, and pushed it. This commit should
also be part of the review for this ticket.
--
Ticket URL: <http://bind10.isc.org/ticket/2096#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list