BIND 10 #2165: update Message::addRRset() to be unaware of signedness

[BIND 10 Development]

#2165: update Message::addRRset() to be unaware of signedness
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => UnAssigned
 * status:  assigned => reviewing


Comment:

 The bug is up for review.

 Please note the following points:

 * The work is in the `trac2165_2` branch.
 * Whoever picks up this bug for review will also have to assign #2166 to
 themselves (for review) as both are in the same branch. Please first
 assign both bugs to yourself before beginning review.
 * Some precursor tests were added in #2164 so that #2165 and #2166 could
 be tested.
 * Jinmei has pointed out an issue with commit
 `ef85853043e2d5f1fe3c2d494cd4af3b553d88fa` which remains to be addressed,
 but you can review the rest of the work in parallel as it's another review
 comment:
 https://lists.isc.org/pipermail/bind10-dev/2012-August/003731.html
 * The commits are cleanly separated. Only
 `ace794f6a528370d1533790512836870a89b4344` is large as it involved
 removing the sign argument from the call tree.
 * I have verified that lettuce passes here.
 * One important note: for every change that involved fixing a testcase or
 testdata, please check carefully based on the testcase whether that was
 the correct thing to do. I think some of the tests expected incorrect
 results before.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2165#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development