BIND 10 #2165: update Message::addRRset() to be unaware of signedness

BIND 10 Development do-not-reply at isc.org
Wed Aug 22 05:02:35 UTC 2012


#2165: update Message::addRRset() to be unaware of signedness
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:5 muks]:
 > * Jinmei has pointed out an issue with commit
 `ef85853043e2d5f1fe3c2d494cd4af3b553d88fa` which remains to be addressed,
 but you can review the rest of the work in parallel as it's another review
 comment:
 https://lists.isc.org/pipermail/bind10-dev/2012-August/003731.html

 This is now fixed too. More tests needed adjusting. But now tests in the
 Python bindings fail due to this change:

 {{{
 @@ -866,7 +868,8 @@ DatabaseClient::Finder::findOnNameResult(const Name&
 name,
          // includes the case where we were explicitly querying for a
 CNAME and
          // found it.  It also includes the case where we were querying
 for an
          // NS RRset and found it at the apex of the zone.)
 -        return (ResultContext(SUCCESS, wti->second, flags));
 +        return (ResultContext(SUCCESS, stripRRsigs(wti->second, options),
 +                              flags));
      }
 }}}

 It throws an exception that "database is locked" in
 `SQLite3Accessor::startUpdateZone()`. I am trying to figure out why that
 happens.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2165#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list