BIND 10 #2136: update the stats daemon according to the new statistics model

BIND 10 Development do-not-reply at isc.org
Fri Aug 24 05:09:38 UTC 2012


#2136: update the stats daemon according to the new statistics model
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  statistics                         |  Estimated Difficulty:  8? (depends
                   Keywords:         |  on #2135)
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => naokikambe


Comment:

 Hi Kambe-san

 I apologise for the delay in reviewing this bug. I was caught up in fixing
 #2165 which took much longer than expected.

 * The changes made for the review comments seem ok. `make check` and
 Lettuce tests pass. I have not re-run the system tests as many of these
 are commented out as they need implementation in other components.
 * In `Stats.command_show()`, should the call to `update_statistics_data()`
 pass `owner` instead of `self.module_name`?
 * Does this require a ChangeLog entry? I think adding one in any case
 would be nice as it changes the basic design of statistics gathering.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2136#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list