BIND 10 #2136: update the stats daemon according to the new statistics model

[BIND 10 Development]

#2136: update the stats daemon according to the new statistics model
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120904
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  statistics                         |  Estimated Difficulty:  8? (depends
                   Keywords:         |  on #2135)
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => muks


Comment:

 Hello Mukund-san,

 No worries, it's too big change for a ticket.

 Replying to [comment:19 muks]:
 > * The changes made for the review comments seem ok. `make check` and
 Lettuce tests pass. I have not re-run the system tests as many of these
 are commented out as they need implementation in other components.

 We need to uncomment them after merging trac2138.

 > * In `Stats.command_show()`, should the call to
 `update_statistics_data()` pass `owner` instead of `self.module_name`?

 Yes. self.module_name is Stats and owner is a possible module name, e.g.
 Stats, Auth, Xfrout and so on. If it updates statistics data of Stats,
 owner is set to Stats. In other case, if it updates statistics data of
 Auth, owner is set to Auth.

 > * Does this require a ChangeLog entry? I think adding one in any case
 would be nice as it changes the basic design of statistics gathering.

 Yes, it does. I pasted it [comment:4 above]. Did you read it?

 Thanks,

-- 
Ticket URL: <http://bind10.isc.org/ticket/2136#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development