BIND 10 #2136: update the stats daemon according to the new statistics model
BIND 10 Development
do-not-reply at isc.org
Sun Aug 26 20:45:45 UTC 2012
#2136: update the stats daemon according to the new statistics model
-------------------------------------+-------------------------------------
Reporter: | Owner: naokikambe
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20120904
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DNS
statistics | Estimated Difficulty: 8? (depends
Keywords: | on #2135)
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => naokikambe
Comment:
Hi Kambe-san
Replying to [comment:20 naokikambe]:
> > * In `Stats.command_show()`, should the call to
`update_statistics_data()` pass `owner` instead of `self.module_name`?
>
> Yes. self.module_name is Stats and owner is a possible module name, e.g.
Stats, Auth, Xfrout and so on. If it updates statistics data of Stats,
owner is set to Stats. In other case, if it updates statistics data of
Auth, owner is set to Auth.
I follow.. this looks fine then as it's updating Stat's keys.
> > * Does this require a ChangeLog entry? I think adding one in any case
would be nice as it changes the basic design of statistics gathering.
>
> Yes, it does. I pasted it [comment:4 above]. Did you read it?
I missed reading it. :) It looks fine, so you can commit the ChangeLog
entry too when merging this ticket #2136, and update it with other ticket
numbers when you merge the other tickets.
I think you can go ahead and merge now. :)
--
Ticket URL: <http://bind10.isc.org/ticket/2136#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list