BIND 10 #2442: update TXTLikeImpl with from lexer constructor

[BIND 10 Development]

#2442: update TXTLikeImpl with from lexer constructor
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:11 jinmei]:
 > > I believe the reported message should have the `-1` adjustment here
 too:
 > > {{{#!c++
 > >     if (result.size() > MAX_CHARSTRING_LEN + 1) { // '+ 1' due to the
 len field
 > >         isc_throw(CharStringTooLong, "character-string is too long: "
 <<
 > >                   result.size() << " bytes");
 > >     }
 > > }}}
 >
 > I think it's a matter of interpretation, and while I don't necessarily
 > oppose to that, the current interpretation seems to be closer to what
 > the RFC states:
 >
 > {{{
 > <character-string> is a single
 > length octet followed by that number of characters.  <character-string>
 > is treated as binary information, and can be up to 256 characters in
 > length (including the length octet).
 > }}}

 What I'm worried about is most users don't read RFCs at all, or in better
 case,
 that thoroughly to grasp that implication. So, while your approach is
 indeed
 defensible, I think a user that sees the message could just start counting
 the
 character he wrote there and be off by 1. Maybe not say „bytes“, but
 „characters“ (because one of the byte isn't actually a character, but
 length)?

 Anyway, this is minor, so if you agree or not, please merge afterwards.

 About the failing test, sorry, it was a timing issue, but it happened 3
 times
 in a row. Then, when I was writing the comments, I ran it once again and
 copy-pasted and didn't check it didn't fail at that time.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2442#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development