BIND 10 #2442: update TXTLikeImpl with from lexer constructor

[BIND 10 Development]

#2442: update TXTLikeImpl with from lexer constructor
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:12 vorner]:

 > > I think it's a matter of interpretation, and while I don't necessarily
 > > oppose to that, the current interpretation seems to be closer to what
 > > the RFC states:
 > >
 > > {{{
 > > <character-string> is a single
 > > length octet followed by that number of characters.  <character-
 string>
 > > is treated as binary information, and can be up to 256 characters in
 > > length (including the length octet).
 > > }}}
 >
 > What I'm worried about is most users don't read RFCs at all, or in
 better case,
 > that thoroughly to grasp that implication. So, while your approach is
 indeed
 > defensible, I think a user that sees the message could just start
 counting the
 > character he wrote there and be off by 1. Maybe not say „bytes“, but
 > „characters“ (because one of the byte isn't actually a character, but
 length)?

 I see the point, but at the same time doing -1 looks like doing
 something not technically correct.  So as a compromise I've revised
 the message as follows:
 {{{#!cpp
         isc_throw(CharStringTooLong, "character-string is too long: " <<
                   (result.size() - 1) << "(+1) characters");
 }}}

 > Anyway, this is minor, so if you agree or not, please merge afterwards.

 and, assuming details on this point isn't a blocking issue, I merged
 the branch.  Now closing the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2442#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development