BIND 10 #2377: define dns::MasterLoad class

[BIND 10 Development]

#2377: define dns::MasterLoad class
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  7             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:24 jinmei]:
 > > No, I mean where should I leave the note.
 >
 > I meant in the code.

 OK, I added a note about SOA check to the code. I guess there'll be more
 tiny
 things like this, we'll probably want to have a cleanup walk through the
 code
 once the whole feature is finished.

 > > It was one of the comments I didn't have time for on Friday, maybe I
 didn't say
 > > it explicitly enough. It is handled now.
 >
 > It seems it only handles the case where EOF is encountered in error
 > handling.  If I read it correctly, this case is also handled at the
 > end of successful load (only with an abrupt EOF) in BIND 9.

 I didn't find that handling in bind9 ‒ I found only one place where
 `read_till_eof` was assigned true, and that was in error handling.

 Anyway, the current code does handle the EOF even in successful case, as
 it
 calls the function to create Rdata ‒ it does that. I added a test to
 confirm it.

 There'll be need to check that after $ directives, but that's a different
 ticket and I plan to unify the code for the error handling and the
 directives
 in the #2428 ticket.

 > I'd also make the warning message as compatible with BIND 9 as
 > possible unless there's a reason for not doing so:
 > {{{#!cpp
 >                         callbacks_.warning(lexer_.getSourceName(),
 >                                            lexer_.getSourceLine(),
 >                                            "file does not end with
 newline");
 > }}}

 Done.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2377#comment:25>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development