BIND 10 #2377: define dns::MasterLoad class

[BIND 10 Development]

#2377: define dns::MasterLoad class
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  7             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:25 vorner]:

 > > > It was one of the comments I didn't have time for on Friday, maybe I
 didn't say
 > > > it explicitly enough. It is handled now.
 > >
 > > It seems it only handles the case where EOF is encountered in error
 > > handling.  If I read it correctly, this case is also handled at the
 > > end of successful load (only with an abrupt EOF) in BIND 9.
 >
 > I didn't find that handling in bind9 ‒ I found only one place where
 > `read_till_eof` was assigned true, and that was in error handling.

 Ah, okay, it looks like so.

 > Anyway, the current code does handle the EOF even in successful case, as
 it
 > calls the function to create Rdata ‒ it does that. I added a test to
 confirm it.

 I don't think we need a test for that case in `MasterLoader`; it's
 beyond the responsibility to it (As commented above, I misunderstood
 the original BIND 9 code on this point).  I suggest removing the
 noEOLN test.

 Now, there's one remaining substantial issue.  Maybe I shouldn't have
 split the comment and it was probably overlooked due to that, but this
 point is still open to me:
 http://bind10.isc.org/ticket/2377?replyto=25#comment:22

-- 
Ticket URL: <https://bind10.isc.org/ticket/2377#comment:26>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development