BIND 10 #2546: DHCP Lease Manager - miscellaneous updates

[BIND 10 Development]

#2546: DHCP Lease Manager - miscellaneous updates
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20121213
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 I verified your fixes with cppcheck and all listed issues are now gone.

 There are some little things that I had not found earlier:
 '''pkt4.cc'''

 Also, the date in the copyright header of this file should be updated
 after file modification.

 setHWAddr: variable name '''macAddr''' is against BIND10 coding
 guidelines. It should be mac_addr.

 setSname: this is loosely related to your changes but appears to me that
 the use of '''const uint8_t*''' is unsafe. You refer to sname[0]  while
 there is no guarantee that it sname is a valid pointer to a string.

 '''!ChangeLog'''
 Shouldn't that be !''resolving some cppcheck/Doxygen issue'''s''' !'' #
 's' at the end?

 Also, I would categorize it as "bug fix" rather than "functional" change.
 In such case it should be [bug] rather than [func] in the !ChangeLog entry
 header.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2546#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development