BIND 10 #2546: DHCP Lease Manager - miscellaneous updates

[BIND 10 Development]

#2546: DHCP Lease Manager - miscellaneous updates
-------------------------------------+-------------------------------------
            Reporter:  stephen       |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20121213
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 >  Also, the date in the copyright header of this file should be updated
 after file modification.
 Done

 > setHWAddr: variable name macAddr is against BIND10 coding guidelines. It
 should be mac_addr.
 Changed.

 > setSname: this is loosely related to your changes but appears to me that
 the use of const uint8_t* is unsafe. You refer to sname[0] while there is
 no guarantee that it sname is a valid pointer to a string.
 The problem was there already in the memcpy, but all the same, good catch.
 I've added a check for the pointer being null and throw an exception if
 so.  The same check has been added to the constructor.

 > !ChangeLog
 All points valid, will alter when I write the log entry.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2546#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development