BIND 10 #2431: support flexible ordering/appearance of TTL, type and class in dns::MasterLoader

[BIND 10 Development]

#2431: support flexible ordering/appearance of TTL, type and class in
dns::MasterLoader
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20121218
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jinmei


Comment:

 Replying to [comment:12 jinmei]:
 > This re-review is changes up to 757d91f.  It generally looks okay
 > and ready for merge (when #2429 is ready).  I have two additional
 > editorial comments.
 >
 > - I suggest adding some simple description of parseRRParams like this:
 > {{{#!cpp
 >     // A helper method for loadIncremental.  It parses part of an RR
 >     // until it finds the RR type field.  If TTL or RR class is
 specified
 >     // before the RR type, it also recognize and validate them.
 >     // explicit_ttl will be set to true if this method finds a valid TTL
 >     // field.
 > }}}
 > - I suggest using `InternalException` instead of `BadValue` and remove
 >   the comments.
 > {{{#!cpp
 >             // It doesn't really matter much what type of exception
 >             // we throw, we catch it just below.
 >             isc_throw(isc::BadValue, "Class mismatch: " << *rrclass <<
 >                       "vs. " << zone_class_);
 > }}}
 >   `InternalException` seems to be introduced for this exact purpose,
 >   but I guess at the time of the use of `BadValue` it wasn't there.

 Done. Please check the `trac2431_2` branch for this.

 I'll keep this bug open and close it during the next sprint. I want the
 rest of the code also to get into master soon.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2431#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development